forked from microsoft/playwright
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] main from microsoft:main #247
Open
pull
wants to merge
971
commits into
FANGOD:main
Choose a base branch
from
microsoft:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+89,574
−28,433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Installation tests can fail due to e.g. network issues. Lets align with library tests and retry up to 3 times.
…#32893) This is fixing a case where the test failed with strict mode violation, but all the matched elements are not highlighted in the trace. For example, all the buttons will be highlighted when the following line fails due to strict mode violation: ```ts await page.locator('button').click(); ``` To achieve this, we mark elements during `querySelector` phase instead of inside `onBeforeInputAction`. This allows us to only mark from inside the `InjectedScript` and remove the other way of marking from inside the `Snapshotter`.
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Closes #32853 Vite turns the shorthand fragment notation `<></>` into `import { Fragment } from "react"; <Fragment></Fragment>`. On the Node.js side of things, this `react` import resolves to our mock version of React, which currently mocks `Fragment` as `{}`. Currently, we pass that straight to `React.createElement`, which throws an error. The fix is to make our `Fragment` mock detectable with a tag, and when we render it replace it with the real `__pwReact.Fragment`.
In #32861, an interested .NET user wanted to try Playwright and found the VS Code Getting Started guide. It didn't work for them because the VS Code Extension is for usage with Node.js, and they don't have NPM installed. We can reduce confusion by mentioning that VS Code Getting started is for Node.js. --------- Signed-off-by: Simon Knott <info@simonknott.de>
Closes #32915. In the `Call` and `Logs` tabs, we update the contents based on the hovered action. We document that this is also the case for the `Source` tab: https://github.com/meeroslaph/playwright/blob/78054a7652377a316669e21163ede3d8dbc0d99c/docs/src/test-ui-mode-js.md?plain=1#L61-L65 But it isn't. Not sure if it's a regression or not, but this PR fixes it.
The folks who opened #32925 would benefit from filtering by annotation existence. Turns out we already have it! This PR adds a test to ensure it stays that way.
Disabling as it produces [too much output](#32908 (comment)).
When the list of highlighted elements changes over time, we should update the elements marked as `__playwright_target__` in the snapshot. A good example is an `expect(locator).toHaveText([...])` where the list of elements changes from 4 items to 3 after clicking a "Delete" button.
One test is removed, since it's impossible to fix. Hopefully, the rest will pass.
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Similarly to Firefox, move the mouse to (-1, -1) upon page reuse. This fixes the corresponding test on all platforms.
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Closes #32809 We were writing onto the wrong object.
Closes #32925. Before this change, newlines in annotation descriptions weren't respected. This change makes them shown. Here's how it looks for this annotation: ```ts test.info().annotations.push({ type: 'user story', description: '\n- user goes to the page\n- user clicks the button\n- user sees the result', }); ``` Before: <img width="1071" alt="Screenshot 2024-10-04 at 09 55 15" src="https://github.com/user-attachments/assets/89e74ff5-ea83-48da-a33b-833423916d95"> After: <img width="1031" alt="Screenshot 2024-10-04 at 09 51 08" src="https://github.com/user-attachments/assets/0f2914e8-bd88-4970-aa68-6a5a9828295c">
) This includes all actions that perform locator handler check. Note this makes it impossible to interact with the page while a main frame navigation is ongoing. This was already the case for Chromium, but now WebKit and Firefox align with it. Setting `PLAYWRIGHT_SKIP_NAVIGATION_CHECK` environment variable disables this behavior.
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )